krime / serf

Automatically exported from code.google.com/p/serf
Apache License 2.0
1 stars 0 forks source link

Either prototype functions or make them static #96

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. compile with -Wmissing-prototypes

What is the expected output? What do you see instead?
expected: no warnings.
gcc -o buckets/buckets.o -c -g -O2 -std=c89 -Wall -Wmissing-prototypes -pthread 
-D_REENTRANT -D_GNU_SOURCE -I. -I/usr/include -I/usr
/include/apr-1 buckets/buckets.c
buckets/buckets.c:579:6: warning: no previous prototype for 'serf__log' 
[-Wmissing-prototypes]
buckets/buckets.c:595:6: warning: no previous prototype for 'serf__log_nopref' 
[-Wmissing-prototypes]
buckets/buckets.c:606:6: warning: no previous prototype for 'serf__log_skt' 
[-Wmissing-prototypes]
...
gcc -o buckets/response_buckets.o -c -g -O2 -std=c89 -Wall -Wmissing-prototypes 
-pthread -D_REENTRANT -D_GNU_SOURCE -I. -I/usr/include -I/usr/include/apr-1 
buckets/response_buckets.c
buckets/response_buckets.c:419:14: warning: no previous prototype for 
'serf_response_full_become_aggregate' [-Wmissing-prototypes]

What version of the product are you using? On what operating system?
SVN-HEAD

Please provide any additional information below.
suggested patch to make these issues visible in future:
Index: SConstruct
===================================================================
--- SConstruct  (revision 1825)
+++ SConstruct  (working copy)
@@ -100,6 +100,7 @@
   ccflags = ['-g', '-O2', '-std=c89', ]
   if sys.platform != 'sunos5':
     ccflags.append('-Wall')
+    ccflags.append('-Wmissing-prototypes')

 libs = [ ]
 if 1:

Original issue reported on code.google.com by 0x1...@googlemail.com on 6 May 2013 at 2:09

GoogleCodeExporter commented 9 years ago
Issue is solved with r1861 and r1863. Thanks for the suggestion!

Original comment by lieven.govaerts@gmail.com on 20 May 2013 at 11:27