search

krimtonz / kz

MM Practice Rom
GNU General Public License v3.0
47 stars 11 forks source link

Memwatch Cosmetic Issues #1

Open rylieb opened 4 years ago

rylieb commented 4 years ago

Memwatches in KZ have some cosmetic issues, at least in commit: 48b7c66cd10d06eb957395589dfce1d2abd3aa3a, KZSE full version, Wii VC. It's possible newer commits or different KZ versions might not have the issues.

  1. Memwatches are left-aligned. This causes them to jump horizontally around the screen as the value gets more or fewer digits.
  2. Long memwatch names get corrupted upon reset/profile load.
  3. Deleting memwatches that aren't at the bottom of the list corrupts the memwatch menu.

Unlisted YouTube video with timestamps showing the issues

krimtonz commented 4 years ago

Thank you for your feedback!

Commit 4fe28f6e521f58ffb8aa7d56489e6f4f6ffbcc2f fixes issues 2 and 3.

Issue 1 might need some design consideration.

rylieb commented 4 years ago

Thanks for fixing issues 2 and 3!

Regarding issue 1: I've been told GZ aligns memwatches with the decimal point for floats, or with the rightmost numerical digit for integers/hex. I don't play OoT though so it's only word of mouth. If that's too difficult, aligning with the rightmost character in the label would also be preferable to the current state of affairs.