search

kripken / ammo.js

Direct port of the Bullet physics engine to JavaScript using Emscripten
Other
4.19k stars 559 forks source link

Make compatible with NWJS #420

Open Neptilo opened 1 year ago

Neptilo commented 1 year ago

In NWJS, __dirname doesn't exist in the global scope but in a namespace called global.

Neptilo commented 1 year ago

Hi Will, I don't understand. The URL you sent precisely refers to the same repo that I forked. How would those edits be overwritten?

On Thu, 14 Sept 2023 at 18:26, Will Eastcott @.***> wrote:

Thanks for this. But we take ammo.js from this repo:

https://github.com/kripken/ammo.js/tree/main/builds

We'll no doubt grab updates from there over time and we'll likely lose these edits. Have you considered posting an issue on the ammo.js repo to say you'd like the builds to be compatible with NWJS?

— Reply to this email directly, view it on GitHub https://github.com/kripken/ammo.js/pull/420#issuecomment-1719770549, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGMBLKZILQPUXDIORU434TX2MV2HANCNFSM6AAAAAA4YMGX5I . You are receiving this because you authored the thread.Message ID: @.***>

willeastcott commented 1 year ago

@Neptilo Ignore that previous (since-deleted) message. I mistakenly thought this was logged on the PlayCanvas repo - and, of course, it isn't. 😄