kripken / box2d.js

Port of Box2D to JavaScript using Emscripten
1.32k stars 198 forks source link

Added support for Box2D feature; Improved Makefile #33

Closed Joncom closed 11 years ago

Joncom commented 11 years ago

Going to try adding support for b2MassData via embind instead!

kripken commented 11 years ago

Sorry for the late response. Yes, embind would be a good idea here.

Joncom commented 11 years ago

Just to let you know, I did get b2MassData and other classes to bind nicely using embind. However I've stopped all work on this port because despite exposing these classes, the port remains broken. For example, despite b2MassData being exposed, body.GetMassData() still returns a pointer-not-found error.

On Jul 7, 2013, at 12:07 PM, Alon Zakai notifications@github.com wrote:

Sorry for the late response. Yes, embind would be a good idea here.

— Reply to this email directly or view it on GitHub.

kripken commented 11 years ago

Do you mean that there is a bug in the port using embind? Is this a new port or some sort of combination with the old one? In other words, is this a bug in the old bindings or definitely in embind? If embind, please file a testcase so we can reproduce and fix.

Joncom commented 11 years ago

The port was your current repo, plus some extra embinds I added. I attempted to fix the problem, which I've now made an issue for here, and I had assumed that it was caused by b2MassData having not yet been bound. So I bound it using embind. It did not make a difference at all. It still produced the very same error message.

kripken commented 11 years ago

Embind and the old bindings generator are not meant to be used together. The long-term goal should be to convert entirely to embind, and stop using the old bindings generator.