search

kripken / xml.js

Port of libxml to JavaScript using Emscripten
Other
174 stars 67 forks source link

Remove statement that kills node server after .5s #20

Closed jbeard4 closed 6 years ago

jbeard4 commented 6 years ago

When running xmllint in a node.js server, the server process would die after .5s. Removing the statement that calls process.exit after a .5s timeout fixes this bug. The statement I removed is setTimeout((function(){process["exit"](status)}),500)

warjohn123 commented 6 years ago

👍

warjohn123 commented 6 years ago

Hi I need this PR to be merged so that it will fix the bug im having right now

sterpe commented 6 years ago

The reason this PR hasn't been accepted, in addition to the lack of active development here in general, is that this is not the right kind of fix. This is a direct hand modification of emscripten compilation. This is not scalable and would be broken again the very next time the project were recompiled.

So I won't accept this PR and will close it.

In general, this library is intended as a port of xmllint for the browser, not node. I don't understand what the benefit of using an emscripten port of xmllint in node would be, versus, the much better approach of installing xmllint via yum or apt-get on your servers and using node's child_process api to shell this out to actual xmllint binary, which has more features and is also faster.

If you really insist on using xml.jsfrom node, as far as what you can do @warjohn123, I would recommend forking this repo, applying the patch there, then publishing it to npm as a namespaced module for use in your own project.