search

kripod / react-polymorphic-box

Building blocks for strongly typed polymorphic components in React.
MIT License
348 stars 14 forks source link

displayName and propTypes are not allowed on forwardRef component #22

Open tu4mo opened 3 years ago

tu4mo commented 3 years ago

Description

Using displayName and propTypes on a forwardRef component shows error. I guess this is more of an issue with the example code than this library.

Reproduction

https://codesandbox.io/s/typescript-as-prop-with-react-polymorphic-box-forked-hw0l5?file=/src/App.tsx

Expected behavior

displayName and propTypes should be allowed.

Actual behavior

displayName and propTypes are not allowed.

kripod commented 3 years ago

Thank you for the report! I’ve just started to work on refactoring this library into a new, smaller and better one. The work may take a while, but until then, I’m not planning to fix the examples provided for this library.

tu4mo commented 3 years ago

Awesome! Looking forward to it.

kripod commented 3 years ago

@tu4mo I’ve just released react-polymorphic-types which includes types specialized for React.forwardRef, React.memo and React.lazy.