search

kripton / kripton-overlay

Gentoo portage overlay with packages needed or developed by kripton
0 stars 1 forks source link

www-apps/phpvirtualbox-6.1.0.9999 remarks #4

Open jonasstein opened 2 years ago

jonasstein commented 2 years ago

DEPEND="app-arch/unzip

do you really need this dependency? If you pull from git, or use tar.gz you do not need this additional dep.

KEYWORDS="~amd64 ~x86" must be KEYWORDS="" for live (9999) ebuilds. Simply remove KEYWORDS="~amd64 ~x86"completely

rm -f CHANGELOG.txt LICENSE.txt README.md needs || die

the source in metadata.xml is wrong https://github.com/kripton/kripton-overlay/blob/master/www-apps/phpvirtualbox/metadata.xml#L9

kripton commented 2 years ago

Thanks for the feedback! Indeed, the dependency on unzip was from when the ebuild downloaded the snapshots as an archive. I'll prepare some snapshot-based ebuilds in addition to the live ebuild and fix the other issues as well :+1: