krischer / instaseis

Instant high-frequency seismograms from an AxiSEM database
http://instaseis.net
Other
52 stars 23 forks source link

Clarify direction of r, theta, phi unit vectors #74

Closed liamtoney closed 4 years ago

liamtoney commented 4 years ago

In trying to create a ForceSource object, I was unclear of the direction of the r, theta, and phi hat vectors (mainly the latter two). I found a definition in Nissen-Meyer et al. (2008), Figure 1:

Screen Shot 2020-06-16 at 4 00 25 PM

This suggests that — relative to someone standing on Earth's surface — r is positive upwards, theta is positive to the south, and phi is positive to the east. Is this the correct definition? If so, I would kindly suggest including a reference to the paper (as implemented in this PR) for some clarity.

Thanks!

(The RST formatting might be wrong here, I was just guessing.)

krischer commented 4 years ago

r, theta, and phi refer to the standard spherical coordinate system that to my understanding is in use in most of physics (up to the point of it being an official ISO standard). It is the same coordinate system that is also used for moment tensor sources.

I like the idea of adding an explanation. Could you please make two small changes then I'd be happy to merge it:

liamtoney commented 4 years ago

Cool, I've made those changes.

krischer commented 4 years ago

Thanks a bunch!