krischer / jane

Jane - Document Database for Seismology
http://krischer.github.io/jane
GNU General Public License v3.0
27 stars 9 forks source link

Allow longer network/station codes? #53

Closed megies closed 7 years ago

megies commented 7 years ago

In some parts, currently only 2/5 characters are allowed for network/station codes (e.g. https://github.com/krischer/jane/pull/52/files#diff-a42b6eea0a64296437fd47dfd165fbfcR239). This should probably be relaxed at some point..

krischer commented 7 years ago

Why do you want to do this? This limitation is still part of all current FDSN formats. It will indeed likely be relaxed in the future - once the new formats exist we can totally adapt the databases I guess. Or am I missing something?

megies commented 7 years ago

This limitation is still part of all current FDSN formats.

Well, implicitly yes, explicitly no. The FDSN StationXML xsd schema actually imposes no restrictions on Station/Channel code lenght whatsoever. So basically the current setup makes Jane reject (or cripple? I didnt test either way) valid StationXML files.

krischer commented 7 years ago

StationXML follows SEED where things are undefined and SEED and mini-SEED limit NET.STA.LOC.CHA identifiers to 2/5/2/3 characters, respectively. In the fdsnws manual identifiers are also called "SEED identifiers or codes". So its true that it is not explicit in the schema but in practice it is always the case.

Changing this is the pretty much the biggest motivation for creating a new mini-SEED version.

megies commented 7 years ago

Ah right, it wouldn't make much sense to define a station in StationXML with a longer code when the code can't be specified in the waveforms in MiniSEED. So I guess it really is safe to assume that a StationXML with longer station/channel codes can be done but would likely only really work in practice when using something else than MiniSEED for waveforms storage (and I guess most datacenters use MiniSEED). So, yeah, I guess we can put this off till later.