Implements some fixes for Django 2.0

krisfields / django-baker

Adds a management command that generates views, forms, urls, admin, and templates based off the contents of models.py

BSD 3-Clause "New" or "Revised" License

389 stars 51 forks source link

Implements some fixes for Django 2.0 #20

Closed alkelaun closed 6 years ago

alkelaun commented 6 years ago

I think this breaks Python 2 and some earlier Django compatibility. Biggest fix was namespace issues I was having post Django 1.10.

alkelaun commented 6 years ago

2 Additions:

I'd also like to say, I am very impressed at how well the code worked. Thanks!

This probably shouldn't be merged into the master

krisfields commented 6 years ago

I played around with this a bit today and your changes worked great with python 2.7, 3.6 and Django 1.11/2.0 so I squashed your commits and merged. Sorry it took so longer to take a look -- I just don't have enough free time.

And, of course, thank you for the PR!

agstephens commented 6 years ago

Hi folks, django-baker was really useful for getting started on a recent project where we began with a postgres db, reverse-engineered with python manage.py inspectdb and then built the views, urls and templates with baker. I made my own edits to handle py3.6 so great to see this in master. Thanks 👍