krish300 / settle

daily cash settlement app for small/mid size businesses
MIT License
0 stars 0 forks source link

Close settlement on a past date creates duplicates #122

Closed krish300 closed 4 years ago

krish300 commented 4 years ago

as of now each time we close a settlement it creates a new settlement with default data for next day.

it creates a bug for a use case where admin browses to a previous date settlement and closes it. in that case either of these 2 things should happen

  1. Signals in the api should not be triggered to create a new settlement
  2. in the UI we are not supposed to see close button in sale summary vue

NOTE: on-save trigger also creates a new settlement if the settlement is closed