krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
221 stars 1.25k forks source link

fix-#77:Refactor Form Validation with react-hook-form & zod #296

Closed ShristiSharan closed 6 months ago

ShristiSharan commented 6 months ago

Summary

This PR address 1.Validation schema modification 2.Form validation logic enhancement

  1. Image selection Improvements

Description

Added react hook form and zod which helps in validating the input fields and to show the error as user fills the required input field rather than showing error after complete submission. The validation schema has been updated to include checks for the author's name length and the maximum number of selected categories, image selection, blog title length and description of blog to be posted.

Users now have the option to select an image for their blog post either by providing a URL or uploading a file from their device. Additionally, feedback is provided to the user upon image selection.

Images

Helping user to fill the input as per requirement beforehand:

image

and once corrected, error gets removed- image

Issue(s) Addressed

Closes #77

Prerequisites

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ❌ Failed (Inspect) May 22, 2024 4:42am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 4:42am
krishnaacharyaa commented 6 months ago
image

Build is failing because of above

Kindly make sure you follow everything from the previous PR thread, let's finish this asap. Its too much time passed... https://github.com/krishnaacharyaa/wanderlust/pull/254

Mainly The error messages and validations Video showing the implementation All the review comments of #254

krishnaacharyaa commented 6 months ago

Kindly rebase for the PR title checker to pass

krishnaacharyaa commented 6 months ago

@ShristiSharan you can delete the package-lock.json and then do npm install that should ideally solve the build failure

ShristiSharan commented 6 months ago

okh sir, will do this asap

ShristiSharan commented 6 months ago

@ShristiSharan you can delete the package-lock.json and then do npm install that should ideally solve the build failure

Still not working!

krishnaacharyaa commented 6 months ago

@ShristiSharan please arrange a call, may be tomorrow night. It is most needed, and it is quite delayed now

github-actions[bot] commented 6 months ago

Hello ShristiSharan Thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any query kindly check our contributor guidelines.

ShristiSharan commented 6 months ago

@ShristiSharan please arrange a call, may be tomorrow night. It is most needed, and it is quite delayed now

Ohk Sir!