search

krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
206 stars 1.13k forks source link

fix-#257: Hide and visible in password to improve UI #299

Closed GOURAVSINGH19 closed 4 months ago

GOURAVSINGH19 commented 4 months ago

Summary

I improve the sign in and signup page by adding visible and hide password feature which help use to check the password before submit...

https://github.com/krishnaacharyaa/wanderlust/assets/120244528/eb167125-fe64-4de0-8ed5-846aac91aade

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 4:19am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 4:19am
krishnaacharyaa commented 4 months ago

Kindly rebase the branch to latest branch, worflow file has some changes, so that is causing this fail in PR title checking job

GOURAVSINGH19 commented 4 months ago

I don't know why it cannot merge..

krishnaacharyaa commented 4 months ago

Forget about the PR title check , i'll take care of it. @GOURAVSINGH19 kindly update what are the icons you have used and don't touch any other files other than what is required

krishnaacharyaa commented 4 months ago

@GOURAVSINGH19 kindly address the review comments

krishnaacharyaa commented 4 months ago

@GOURAVSINGH19 please change the icons, and don't touch any other icon or update other files, and once all this is done, update the PR description to reflect those icons

github-actions[bot] commented 4 months ago

Thank you GOURAVSINGH19! Your PR title meets our guidelines.

krishnaacharyaa commented 4 months ago

Closing as there is no positive response on the PR reviews