krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
221 stars 1.25k forks source link

updated README.md #304

Closed Meetjain1 closed 6 months ago

Meetjain1 commented 6 months ago

Summary

updated readme.md

Issue(s) Addressed

closes #263

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 6:28pm
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 6:28pm
Meetjain1 commented 6 months ago

All left aligned please. And make sure every emojis are bouncing and animated if possible like the open source wala muscle And instead of :- make it :

There are other content changes, i'll let you know after some time may be tomorrow @Meetjain1

sure

Meetjain1 commented 6 months ago

All left aligned please. And make sure every emojis are bouncing and animated if possible like the open source wala muscle And instead of :- make it :

There are other content changes, i'll let you know after some time may be tomorrow @Meetjain1

done with these changes ,let me know about the other changes @krishnaacharyaa

krishnaacharyaa commented 6 months ago

image

Can we add contributing guidelines even here?

krishnaacharyaa commented 6 months ago

And discord link is invalid

Meetjain1 commented 6 months ago

@krishnaacharyaa have a look now , I think I have completed all the changes you want . and it is ready to merge and to get level3 and gssoc label .😄

Meetjain1 commented 6 months ago

image

Can we add contributing guidelines even here?

I dont think that we can do this by editing readme.md file

krishnaacharyaa commented 6 months ago

Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1

krishnaacharyaa commented 6 months ago

Why is there some space in the right side not used in the contributions section? can we make it a little small, only a little @Meetjain1

Meetjain1 commented 6 months ago

Why is there some space in the right side not used in the contributions section? can we make it a little small, only a little @Meetjain1

okk done

Meetjain1 commented 6 months ago

Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1

adding that jam of link , but gssoc label important links mai hmm.. ok link kaunsi du gssoc mai ? gssoc 24 ki ?

krishnaacharyaa commented 6 months ago

Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1

adding that jam of link , but gssoc label important links mai hmm.. ok link kaunsi du gssoc mai ? gssoc 24 ki ?

No we'll have to figure out, the gssoc has deployed our project in their some website, that link we'll have to put or else if you feel link mei doesn't look good.

Convert the existing description like table of 2 columns , GSSOC logo | description

logo should span across 2 rows got it? @Meetjain1

Meetjain1 commented 6 months ago

Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1

adding that jam of link , but gssoc label important links mai hmm.. ok link kaunsi du gssoc mai ? gssoc 24 ki ?

No we'll have to figure out, the gssoc has deployed our project in their some website, that link we'll have to put or else if you feel link mei doesn't look good.

Convert the existing description like table of 2 columns , GSSOC logo | description

logo should span across 2 rows got it? @Meetjain1

okk done created a table

Meetjain1 commented 6 months ago

@krishnaacharyaa have a look now , I think no changes required now 🙃

krishnaacharyaa commented 6 months ago

@Meetjain1 , the link wala why did you change? I am not able to click anything?

The previous one the content was all good, the blue underline and proper links and stuff,

I wanted you to just change the heading from 💎 to 🔗. Rest all looks really good. Once this is done. kindly raise fresh PR which follows contributing guidelines, so that i can close this as soon as possible. so that you get your points.

Meetjain1 commented 6 months ago

@Meetjain1 , the link wala why did you change? I am not able to click anything?

The previous one the content was all good, the blue underline and proper links and stuff,

I wanted you to just change the heading from 💎 to 🔗. Rest all looks really good. Once this is done. kindly raise fresh PR which follows contributing guidelines, so that i can close this as soon as possible. so that you get your points.

arae mujhe laga aap ye change krne ko bole thae you can click on that link vaala emoji in this case to get links

krishnaacharyaa commented 6 months ago

The previous one was good bro! Blue underline just heading Kindly change

Once you raise new PR which follows the contributing guidelines I'll merge this

Even I'm eager to get this changes in 😍😊

No more changes hopefully @Meetjain1

Meetjain1 commented 6 months ago

The previous one was good bro! Blue underline just heading Kindly change

Once you raise new PR which follows the contributing guidelines I'll merge this

Even I'm eager to get this changes in 😍😊

No more changes hopefully @Meetjain1

Haash ok 👍

Meetjain1 commented 6 months ago

@krishnaacharyaa pr title checker ka issue aaraha hai kya hai ye ?

krishnaacharyaa commented 6 months ago

@Meetjain1 slow down your horses, 5th time I'm saying take your time and raise new PR reading the 5 points in contributing guidelines.

Once your PR follows the commits and PR title according to guidelines will merge this.

krishnaacharyaa commented 6 months ago

@Meetjain1 pardon me, missed the new PR!. Closing this