krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
221 stars 1.25k forks source link

core-#177: Added the eslint in the husky #337

Closed Ameerjafar closed 6 months ago

Ameerjafar commented 6 months ago

Summary

i have added the eslint in the husky folder

Description

initially we have the commit regex and prettier in the husky now I added the airbnb eslint in the husky

Issue(s) Addressed

Enter the issue number of the bug(s) that this PR fixes

Prerequisites

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 11:22am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 11:22am
github-actions[bot] commented 6 months ago

Thank you @Ameerjafar! Your PR title meets our guidelines.

krishnaacharyaa commented 6 months ago

@Ameerjafar pardon me, after research figured out that lets not use the airbnb, lets use the prettier:recommend and eslint:recommended.

Kindly make sure that we use the best configuration out of https://fullstackopen.com/en/part3/validation_and_es_lint#lint In next PR lets make sure that we run the eslint --fix in one PR, so that we don't mix it with this PR.

github-actions[bot] commented 6 months ago

Thank you @Ameerjafar! Your PR title meets our guidelines.

Ameerjafar commented 6 months ago

@krishnaacharyaa can you kindly check now sir.

github-actions[bot] commented 6 months ago

Hey @krishnaacharyaa! Thank you for going through the contributing guidelines. Give Krishna sometime, I hope he'll show up 😜

github-actions[bot] commented 6 months ago

Hey @krishnaacharyaa! Hold your horses 🐴! Thanks for your PR, but we have some style rules around here. Your PR title doesn't quite cut the mustard.

Make sure you follow our contribution guidelines: PR titles should look like fix-#124: Added responsiveness to the Home page screen.

Check out our contributor guidelines for more details. Fix it up, and I'll be happy to take another look 😉.

github-actions[bot] commented 6 months ago

Hey @krishnaacharyaa! Thanks for sticking to the guidelines! High five! 🙌🏻

github-actions[bot] commented 6 months ago

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

github-actions[bot] commented 6 months ago

Hey @krishnaacharyaa! Thanks for sticking to the guidelines! High five! 🙌🏻

github-actions[bot] commented 6 months ago

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

github-actions[bot] commented 6 months ago

Hey @krishnaacharyaa! Thanks for sticking to the guidelines! High five! 🙌🏻

github-actions[bot] commented 6 months ago

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

github-actions[bot] commented 6 months ago

Hey @krishnaacharyaa! Thanks for sticking to the guidelines! High five! 🙌🏻

github-actions[bot] commented 6 months ago

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.