krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
174 stars 826 forks source link

fix-#392: added related blogs section in detailed blog page #398

Closed vamsidhar-914 closed 3 weeks ago

vamsidhar-914 commented 4 weeks ago

Summary

added related blogs section in detailed blog page

Description

whenever user visited individual blog page..they can see related posts based on the categories in the blog page

Images

desktop view Screenshot (200)

mobile view Screenshot (201)

Issue(s) Addressed

Closes #392

Prerequisites

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 6:05am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 6:05am
github-actions[bot] commented 4 weeks ago

Hey @vamsidhar-914! Thanks for sticking to the guidelines! High five! 🙌🏻

github-actions[bot] commented 4 weeks ago

Hey @vamsidhar-914! Thanks for sticking to the guidelines! High five! 🙌🏻

vamsidhar-914 commented 4 weeks ago

hey @krishnaacharyaa please do review it and want any changes then tell me 👍

vamsidhar-914 commented 3 weeks ago

helllo @krishnaacharyaa ??

krishnaacharyaa commented 3 weeks ago

And kindly add the images in the PR description or a video

vamsidhar-914 commented 3 weeks ago

@krishnaacharyaa ok sure im on itt

vamsidhar-914 commented 3 weeks ago

hi @krishnaacharyaa

fetched all related category posts and displayed 3 posts in mobile view and 4 posts in desktop view added images in the PR description

github-actions[bot] commented 3 weeks ago

Hey @vamsidhar-914! Thanks for sticking to the guidelines! High five! 🙌🏻

krishnaacharyaa commented 3 weeks ago

For mobile can we aim for this kind (style) of related posts?

image

small icon in the left and then the content on the right.

If you feel these are quite a few requests in a single PR, kindly let me know we can break this into subtasks, and we can raise this as another PR :) I'm totally fine with that

vamsidhar-914 commented 3 weeks ago

no its finee...i'll be on it

vamsidhar-914 commented 3 weeks ago

@krishnaacharyaa

changed naming conventions added mobile responsive for related posts Screenshot (206)

vamsidhar-914 commented 3 weeks ago

@krishnaacharyaa ?

krishnaacharyaa commented 3 weeks ago

Super @vamsidhar-914 Thank you for the efforts, really appreciated.

Can you use

For the arrow right svg May be this is black version, make white version of it by replacing #000000 with #ffffff and make 2 svgs and kindly handle both dark and light theme

And

image

Can you please take care of this alignment, here the see more related blogs > should be aligned to the below card like

image

And kindly upload the photo of the shimmer/skeleton things aswell, if you feel its too much in a single PR we can take this shimmer loading skeletons in another PR i am fine with that :)

IF you could close the above 2 bugs we are good to merge this PR :)

vamsidhar-914 commented 3 weeks ago

@krishnaacharyaa

fixed svg icons for light and dark mode

added loading skeletons Screenshot (208)

is this alignment ok? or u want any change to it

krishnaacharyaa commented 3 weeks ago

@krishnaacharyaa

fixed svg icons for light and dark mode

added loading skeletons Screenshot (208)

is this alignment ok? or u want any change to it

Can't we have it right side as earlier Just the end should match

You need to use something like justify-between

krishnaacharyaa commented 3 weeks ago

Here I'm not talking about the skeletons I'm just talking about the "Related blogs" and "See all related blogs" that can we have in a single row! That would be nice Just it should be end aligned as I marked in red line in previous comment

vamsidhar-914 commented 3 weeks ago

done it sir @krishnaacharyaa !

krishnaacharyaa commented 3 weeks ago

Thank you sir :)