search

krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
174 stars 826 forks source link

Update signup-page.tsx CSS #421

Closed dhairyagothi closed 1 week ago

dhairyagothi commented 2 weeks ago

Summary

fixed Signup page CSS in mobile view _

Description

_before image

after image

Images

Include any relevant images or diagrams that can help reviewers visualize the changes, if applicable

Issue(s) Addressed

closes #396

Prerequisites

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 2:20am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 2:20am
github-actions[bot] commented 2 weeks ago

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @dhairyagothi Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

dhairyagothi commented 2 weeks ago

please merge PR with gssoc label and assign me

github-actions[bot] commented 2 weeks ago

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @dhairyagothi Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

krishnaacharyaa commented 2 weeks ago

Hi @dhairyagothi kindly take some time and follow https://github.com/krishnaacharyaa/wanderlust/blob/6fa9d7768d6f709abbb7599b7680b27e1f325f5b/.github/CONTRIBUTING.md#guidelines-for-contributions.

And make sure we have 16px of padding left and right , use the tailwind equivalent i guess p-4 and no hardcoding of px values please.

p.s: You might have to raise a new PR because the commit doesn't follow the guidelines! I wonder how you were able to bypass the husky pre-hooks ...., Haven't you actually setup the project? Because pre-hooks should ideally not allow you to commit, the commits which are not following the guidelines

krishnaacharyaa commented 1 week ago

@dhairyagothi can you kindly address the PR comments

dhairyagothi commented 1 week ago

Hi @dhairyagothi kindly take some time and follow https://github.com/krishnaacharyaa/wanderlust/blob/6fa9d7768d6f709abbb7599b7680b27e1f325f5b/.github/CONTRIBUTING.md#guidelines-for-contributions.

And make sure we have 16px of padding left and right , use the tailwind equivalent i guess p-4 and no hardcoding of px values please.

p.s: You might have to raise a new PR because the commit doesn't follow the guidelines! I wonder how you were able to bypass the husky pre-hooks ...., Haven't you actually setup the project? Because pre-hooks should ideally not allow you to commit, the commits which are not following the guidelines

okay sure i am making things coorect give me few moments

dhairyagothi commented 1 week ago

making new PR

krishnaacharyaa commented 1 week ago

@dhairyagothi where are we?

dhairyagothi commented 1 week ago

@dhairyagothi where are we?

Husky is not running in my local system

krishnaacharyaa commented 1 week ago

@dhairyagothi where you able to figure out the root cause? Have you properly followed the instructions made in the readme and setup the project ?

krishnaacharyaa commented 1 week ago

@dhairyagothi

krishnaacharyaa commented 1 week ago

@dhairyagothi Hi, are still interested in this issue? Or can i assign to someone elese