search

krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
174 stars 826 forks source link

[FEATURE] :Want to Add signin with google button #429

Open nishant0708 opened 1 week ago

nishant0708 commented 1 week ago

Description

want to add signin with google button

Use Case

it will make login /signup easier

Proposed Solution

No response

Additional Information

No response

Attachments

No response

krishnaacharyaa commented 1 week ago

Okay go ahead @nishant0708 UI is already in place you have to uncomment, just take care of the backend

github-actions[bot] commented 1 week ago

Hey @nishant0708 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

krishnaacharyaa commented 5 days ago

@nishant0708 working?

NirbhaySingh74 commented 5 days ago

i want to work on it but i am facing problem in redis and not able to connect mongodb locally??

nishant0708 commented 4 days ago

Yes I am I will raise pr by tomorrow

siddharthisrani commented 3 days ago

Hii @krishnaacharyaa can i add the Google login Button?

krishnaacharyaa commented 3 days ago

@siddharthisrani google button UI is already in place but commented out, let me know if you want to integrate by working backend

siddharthisrani commented 3 days ago

@krishnaacharyaa Yes, I would like to work on integrating the backend for this feature.

github-actions[bot] commented 3 days ago

Hey @siddharthisrani 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

krishnaacharyaa commented 1 day ago

@siddharthisrani how far are we?

siddharthisrani commented 1 day ago

@krishnaacharyaa Yes added the login functionality with google , working good but need to change in Header.tsx so that it show the CreatePost and Logout buttons ... And want to Ask that can i change Link Tag into button tag? the "to" path is creating problem for me

krishnaacharyaa commented 1 day ago

And want to Ask that can i change Link Tag into button tag? the "to" path is creating problem for me

If there is no visual changes, go ahead ... but give little more efforts to see if it is possible using Link alone @siddharthisrani

siddharthisrani commented 4 hours ago

Hii @krishnaacharyaa

  1. I stuck on one thing that when i login with Google and try to click on Create post it navigates me to sign page says Unautherised .
  2. Second should i Create new schema model for Google user Because i need to make some field Required False.
krishnaacharyaa commented 4 hours ago

I stuck on one thing that when i login with Google and try to click on Create post it navigates me to sign page says Unautherised .

It's because of not providing acces_token, figure out why it is saying unauthorized and give it the token , for that you will have to first create a token, while signing up

to make some field Required False.

What is that field, and why do you need to mark it as false?