krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
221 stars 1.25k forks source link

[FEATURE] :Want to Add signin with google button #429

Closed nishant0708 closed 4 months ago

nishant0708 commented 5 months ago

Description

want to add signin with google button

Use Case

it will make login /signup easier

Proposed Solution

No response

Additional Information

No response

Attachments

No response

krishnaacharyaa commented 5 months ago

Okay go ahead @nishant0708 UI is already in place you have to uncomment, just take care of the backend

github-actions[bot] commented 5 months ago

Hey @nishant0708 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

krishnaacharyaa commented 5 months ago

@nishant0708 working?

NirbhaySingh74 commented 5 months ago

i want to work on it but i am facing problem in redis and not able to connect mongodb locally??

nishant0708 commented 5 months ago

Yes I am I will raise pr by tomorrow

siddharthisrani commented 5 months ago

Hii @krishnaacharyaa can i add the Google login Button?

krishnaacharyaa commented 5 months ago

@siddharthisrani google button UI is already in place but commented out, let me know if you want to integrate by working backend

siddharthisrani commented 5 months ago

@krishnaacharyaa Yes, I would like to work on integrating the backend for this feature.

github-actions[bot] commented 5 months ago

Hey @siddharthisrani 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

krishnaacharyaa commented 4 months ago

@siddharthisrani how far are we?

siddharthisrani commented 4 months ago

@krishnaacharyaa Yes added the login functionality with google , working good but need to change in Header.tsx so that it show the CreatePost and Logout buttons ... And want to Ask that can i change Link Tag into button tag? the "to" path is creating problem for me

krishnaacharyaa commented 4 months ago

And want to Ask that can i change Link Tag into button tag? the "to" path is creating problem for me

If there is no visual changes, go ahead ... but give little more efforts to see if it is possible using Link alone @siddharthisrani

siddharthisrani commented 4 months ago

Hii @krishnaacharyaa

  1. I stuck on one thing that when i login with Google and try to click on Create post it navigates me to sign page says Unautherised .
  2. Second should i Create new schema model for Google user Because i need to make some field Required False.
krishnaacharyaa commented 4 months ago

I stuck on one thing that when i login with Google and try to click on Create post it navigates me to sign page says Unautherised .

It's because of not providing acces_token, figure out why it is saying unauthorized and give it the token , for that you will have to first create a token, while signing up

to make some field Required False.

What is that field, and why do you need to mark it as false?

siddharthisrani commented 4 months ago

Hii @krishnaacharyaa Fields are FullName, username and Password because Google login doesnt contain these field for This i have to make new seperate Schema for Google login user

krishnaacharyaa commented 4 months ago

@Sukomal07 can you please validate this

Sukomal07 commented 4 months ago

@siddharthisrani I think the new schema is not required for Google login. Make passwords optional, and one thing can you implement Google Login with Passport. js

siddharthisrani commented 4 months ago

@Sukomal07 Implemented with Passport only ! before i was doing with express-session now tried with token too still getting issue ,new issue was It loads infinte after clicking on Create Post... @krishnaacharyaa I am starting from Scratch now .

krishnaacharyaa commented 4 months ago

@siddharthisrani any progress?

siddharthisrani commented 4 months ago

@krishnaacharyaa Stuck on other work and was waiting for your reply...Starting from today apology for the delay.

krishnaacharyaa commented 4 months ago

was waiting for your reply

What reply where you waiting? I just didn't acknowledge, saw this message

@krishnaacharyaa I am starting from Scratch now .

What reply did it demand? am i missing something? It was a statement

siddharthisrani commented 4 months ago

@krishnaacharyaa I was waiting for your comformation too , their was a quite missunderstanding and i was engaged with other project.

krishnaacharyaa commented 4 months ago

You are doing it now ? @siddharthisrani or how is it

siddharthisrani commented 4 months ago

@krishnaacharyaa Yes i am working on it.