krishnaacharyaa / wanderlust

WanderLust is a MERN travel blog website 🚀 This project is aimed to help people to contribute in open source, upskill in react and master git.
https://wanderlust-beta.vercel.app/
MIT License
174 stars 826 forks source link

fix-#432: Bug Fixed #438

Closed kapilG0 closed 4 days ago

kapilG0 commented 4 days ago

Summary

Fixed header for signup and login page in mobile

Description

Header fixed for signup and login page

Images

image image

Issue(s) Addressed

Closes #432

Prerequisites

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 0:25am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 0:25am
github-actions[bot] commented 4 days ago

Hey @kapilG0! Thanks for sticking to the guidelines! High five! 🙌🏻

krishnaacharyaa commented 4 days ago

@kapilG0 take some time, and go through https://tailwindcss.com/docs/responsive-design , and get back, The solution shouldn't be more than 6 to 8 characters meaning it is that minor change, you don't have to create new custom classes and stuff. And forget about the tablet screen,

The task is not to the existing code base of desktop, only in the mobile it needs to be fixed, figure it out

kapilG0 commented 4 days ago

@kapilG0 take some time, and go through https://tailwindcss.com/docs/responsive-design , and get back, The solution shouldn't be more than 6 to 8 characters meaning it is that minor change, you don't have to create new custom classes and stuff. And forget about the tablet screen,

The task is not to the existing code base of desktop, only in the mobile it needs to be fixed, figure it out

Hello @krishnaacharyaa based on above documentation i changed code .please check below images if it is fine then i will raise pr. for mobile image for ipad image for desktop image

krishnaacharyaa commented 4 days ago

Hello @krishnaacharyaa based on above documentation i changed code

Kindly push it, so that I can tell if you are on the right track

kapilG0 commented 4 days ago

Hello @krishnaacharyaa based on above documentation i changed code

Kindly push it, so that I can tell if you are on the right track

i have pushed please check