search

krishnaik06 / Complete-Langchain-Tutorials

GNU General Public License v2.0
321 stars 272 forks source link

Security warning #1

Open fedihamdi opened 10 months ago

fedihamdi commented 10 months ago

Hey Krish,

I took a quick look on your .ipynb and i want to notify you that you should remove the tokens. Maybe use the dotenv to load from .env file as mentionned in the app.

Keep up the good work really enjoy your tutorials. @krishnaik06

kr, Fedi

fedihamdi commented 10 months ago

Hey Krish,

I took a quick look on your .ipynb and i want to notify you that you should remove the tokens. Maybe use the dotenv to load from .env file as mentionned in the app.

Keep up the good work really enjoy your tutorials. @krishnaik06

kr, Fedi

https://github.com/krishnaik06/Complete-Langchain-Tutorials/blame/522bb46dd28cf9083c60a92bce6c6705f122b48a/Q%26A%20Chatbot%20USing%20LLM/langchain.ipynb#L19

Ravikumar10593-hub commented 9 months ago

Hey @fedihamdi , I guess this is only for teaching purposes, so he creates those tokens and deletes them afterward so, there is no need to introduce a new layer or .env file, but I agree on using .env files for all the passwords and tokens.

Thank you for mentioning it, have a great day.