search

krishnanlab / geneplexus-app-v2

GenePlexus App - backend (cloud functions) and frontend
https://gene-plexus.netlify.app/
Other
2 stars 0 forks source link

deleting data processing files #51

Closed ChristopherMancuso closed 1 month ago

ChristopherMancuso commented 2 months ago

It seemed better to have data processing scripts be at GenePlexusZoo_backend. So deleting some files in the PR.

ChristopherMancuso commented 2 months ago

@falquaddoomi I removed some files like we talked about. Also, I've uploaded the new tar.gz files to the GCP bucket. Maybe make sure those files work before closing this PR?

falquaddoomi commented 2 months ago

Hey @ChristopherMancuso, thanks; I just looked over your PR and it seems reasonable.

Once I check that the new files are set up correctly I'll redeploy the GCP functions, check that they work, then approve this PR for you to merge. (Good idea to check them first, thanks for that.)

falquaddoomi commented 1 month ago

Hey @ChristopherMancuso, seems that your changes to the archives fixed the issue; after redeploying the functions I'm able to query both of them successfully. I'll go ahead and approve this, and then we can merge.

FYI, if you ever want to run the function deployment manually (e.g., if you changed the data files in the bucket, which is a change that the current deploy workflow doesn't pick up), you can follow these steps to do so:

  1. Go to https://github.com/krishnanlab/geneplexus-app-v2/actions/workflows/deploy.yaml
  2. Click the "Run Workflow ▼ " button in the blue notice at the top of the list, which will display a small dialog
  3. Check the box "Redeploy GCP functions even if they haven't changed" and then click "Run Workflow"
  4. Refresh the page; you should see a new pending/running action for the deploy