search

krishnanlab / geneplexus_app

BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Search bar subset can't be undone #143

Closed ChristopherMancuso closed 2 years ago

ChristopherMancuso commented 2 years ago

Say on the gene predictions table I want to look at just the Novel genes so I use the search text box and type Novel. Then say I clear the text in the text box, however the table remains subset so there is no way to view the original table unless clicking refresh on the browser. Is it possible to add a button that says "reset table" that would return the table to its original form?

billspat commented 2 years ago

this is on the 'results' page and related to datatables.js search function https://datatables.net/reference/api/search()

I am not having this issue on Safari/Mac. As I add/delete individual characters in the search box,or all of the characters the table results automatically update (e.g. delete Novel and then I can see some that are "known" I've tried with "Novel" but also with portions of Gene IDs.

However If I have the table sorted on the "Known/Novel" column, then I don't see the table change to display the rows with "known," because all the Novels are at the top. There is very little visual clue to indicate that the table is sorted on this column.

@ChristopherMancuso I bet you have already checked this, but can you confirm that the table is not sorted on the Known/Novel column after removing the search text. If this is not the problem which browser are you using on which type of computer? Can you try a different search pattern other than "novel", say some portion of gene id ('RNF' is in the sample gene set) and confirm the table doesn't update when you delete the characters from the search box?

billspat commented 2 years ago

Is this is a problem for some browsers, we can potentially put a 'reset search' button on the page that sends an empty string to the search() function

ChristopherMancuso commented 2 years ago

It was that I had the column sorted on novel so they where just on top of the page. So I would say it works fine. Maybe in the future we could change to make is more evident what the table is being sorted by, but I don't think that is need for now.

billspat commented 2 years ago

thank you Chris - I do think this is a UI issue and it may be easy to use a different CSS for Datatables. Closing the issue

billspat commented 2 years ago

note - created #144 to address this issue at a later date