krishnansuccess / droid-notify

Automatically exported from code.google.com/p/droid-notify
0 stars 0 forks source link

Screen on paramenters when not in use. #224

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Enchancement

What steps will reproduce the problem?
1. Device is not in use, screen is off, device is locked
2. SMS arrives, popup i sdisplayed, screen is turned on, device remains idle 
(user does not interact with device)
3. After a certain timeout set in Notify, the screen is "released" to the 
system and systemn timeout is added on top. Total screen timeout = Notify + 
System

What is the expected output?
After Notify screen on timeout  - screen to be turned off without system 
timeout being added on top.

Version 4.0.9

Additional info:
===============
After rethinking all over, to simplify the things I would just advise to 
evaluate the following option:
Enable force screen OFF after timeout set in Notify if device remains IDLE 
after Notify popup is displayed and if screen was triggered ON by Notify popup 
(previous screen state = off). 
For all other cases – current behavior is OK

==================
Previous thoughts, just for the sake of record tracking:

Indeed, there might be a case when forcing screen off after a “hard” 
timeout is not a good option.

I have amended the scenarios and now they look as following:

Quote:---
- This is the expected behavior. Basically, the Notify app releases it's hold 
on the devices screen. The app no longer is keeping the screen on. After this 
period it's up to the device to turn off the screen. It may stay on if it's 
doing other work or it may stay off. I'll do some research and see if I can 
force the screen to turn off but I don't think that is the correct thing to do. 
What if your device is doing some work and my app then interferes with it? This 
would be a bad thing to do. I'll look into what options are available.
---End of Quote

OK, but this is unwanted behavior if screen/smartphone is locked and smartphone 
remains IDLE as that basically means that NOBODY is working on it and there is 
no need to keep screen on after popup.
Even if device is not locked, but the screen was OFF at the time of the popup 
and device remains IDLE after popup is displayed  – that also means that 
nobody was using it at that point of time and there is no need to keep display 
on after popup.

Scenarios to look into:

1.  Device is locked: capture the device lock status once pop-up is activated. 
If the phone was locked and device remains IDLE after popup is displayed 
(nobody is touching the screen or buttons), force screen OFF after timeout set 
by the user in the Notify settings. If users starts using the device (e.g. 
typing the Quick reply; dismissing / deleting notifications; scrolling the 
notifications collected) – counter is reset after every user interaction  and 
works as  IDLE counter.
Scenario 1: 
device is locked. Timeout in Notify  = 10 sec. Pop-up is displayed, screen 
turned on, dimming is activated (if enabled in the settings)
User does NOT touch the device – device remains IDLE. Screen is turned OFF 
after 10 sec
Scenario 2: 
device is locked. Timeout in Notify  = 10 sec. Pop-up is displayed, screen 
turned on, dimming is activated (if enabled in the settings)
User starts reading the message and would like to use a quick-reply. He starts 
typing a message. It takes 25 seconds for him to respond. After that he stops 
using the device and device remains IDLE. Screen is turned OFF after 10 sec 
from the LAST USER ACTIVITY (35 seconds in total in this scenario)

2.  Device is unlocked: Capture the screen status once pop-up is activated. If 
Display was OFF, application should return it to the same state after timeout 
configured in the Notify settings. Timeout should work as IDLE timeout with the 
same logic as described above
Scenario 3: 
device is UNlocked. Display is OFF. Timeout in Notify  = 10 sec. Pop-up is 
displayed, screen turned on, background dimming is activated (if enabled in the 
settings)
User does NOT touch the device – it remains IDLE. Screen is turned OFF after 
10 sec
Scenario 4.1: 
device is UNlocked. Display is OFF. Timeout in Notify  = 10 sec. Pop-up is 
displayed, screen turned on, background dimming is activated (if enabled in the 
settings)
User starts reading the message and would like to use a quick-reply. He starts 
typing a message. This would reset Notify Idle counter. It takes 25 seconds for 
him to respond. After that he stops using the device and it remains IDLE. 
Screen is turned OFF after 10 sec from the LAST USER ACTIVITY (35 seconds in 
total in this scenario)
Scenario 4.2 (alternative to 4.1, if 4.1 is not feasible): 
device is UNlocked. Display is OFF. Timeout in Notify  = 10 sec. Pop-up is 
displayed, screen turned on, background dimming is activated (if enabled in the 
settings)
User starts reading the message and would like to use a quick-reply. He starts 
typing a message. Users activity disables Notify counter and System settings 
override Notify timeout. Screen is turned OFF in line with IDLE timeout 
configured is system settings.
Scenario 5: 
device is UNlocked. Display is ON. Pop-up is displayed, background dimming is 
activated (if enabled in the settings)
In that scenario Notify timeout is not used. System settings are used instead.

In summary: Notify should revert the screen status to the same state it was 
before popup was activated after IDLE timeout set in Notify options. Timeout 
setting in Notify should work as IDLE timeout.
Please take a closer look into this aspect.

If technically feasible, I would propose the following changes:
1.  Change the logic of Screen timeout setting in Notify to “IDLE Screen 
timeout” (this setting should be in effect only for cases when device screen 
was triggered by Notify and all cases when device was locked).
2.  Enable force display OFF after IDLE timeout in Notify settings instead of 
releasing the hold to the system.
3.  If screen was on AND device was unlocked – system timeout settings 
override Notify settings

From Notify program menu logic – no changes are required. Same settings items 
are used, only logic is changing.

Original issue reported on code.google.com by mclb.e...@googlemail.com on 15 Nov 2013 at 7:15

GoogleCodeExporter commented 9 years ago

Original comment by cs3vi...@gmail.com on 16 Nov 2013 at 1:15

GoogleCodeExporter commented 9 years ago
I am going to add in a new user setting called "Poke Screen". This setting was 
always in use but now I am going to let the users decide when to use this. When 
this next version of the app is released (v4.0.12) the screen should go dark 
after the app releases it unless the user has the "Poke Screen" option selected 
in the user settings.

Original comment by cs3vi...@gmail.com on 3 Dec 2013 at 1:26