search

krishnap25 / mauve

Package to compute Mauve, a similarity score between neural text and human text. Install with `pip install mauve-text`.
https://krishnap25.github.io/mauve/
Other
273 stars 24 forks source link

Allowing other models for extracting features #2

Closed jinyongyoo closed 2 years ago

jinyongyoo commented 2 years ago

Hello!

First off, thanks for sharing the code. In the paper, it says that MAUVE works with other embedding models. Therefore, I wanted to try out models such as DialoGPT from Microsoft. But in the code, it limits the model and tokenizer name to "gpt2" family. I think it would better we remove this restriction since others might also want to try out other models.

If you want, I can make a PR to change this.

https://github.com/krishnap25/mauve/blob/b3c01d5b0f3be85a997b1171b3f2efa3ba16280b/src/mauve/utils.py#L25-L39

krishnap25 commented 2 years ago

Hi @jinyongyoo, a PR for this would be fantastic. Thanks!