search

krishnasaye23 / CollegeAPI

REST API for college service
0 stars 0 forks source link

Service Layer #4

Open krishnasaye23 opened 3 years ago

krishnasaye23 commented 3 years ago
pritish-nitb commented 3 years ago

@krishnasaye23 You can have a look at below points:

  1. Generally we name service interfaces as SchoolService and its implementation as SchoolServiceImpl
  2. Why do you need both @Service and @Component annotations
  3. Have some logic in one of your service classes atleast rather than them being just a passthrough.
  4. Check if you have two implementations of a service class interface how will you autowire a particular implementation.
  5. Check how can you do database transaction management in your methods.