Closed guillaumewuip closed 4 years ago
Did you also mean to make a transpilation change to configs.js
? The idea would be to turn on transpilation for the esm build, this will enable both babel
and buble
to do their thing.
esm: {
entry: resolve('src/index.js'),
dest: resolve(`dist/${FILENAME}.esm.js`),
format: 'es',
env: 'development',
transpile: false // <-- this is the offending line
}
The change, as is, after building, doesn't actually change the build file 😄Perhaps I am missing the intention of this PR then?
Oh yes you're right, I forgot to add this to the PR. It's important for the ESM build to be transpiled to ES5, except for import/export that should be ES6 for webpack or other build tool to tree shake properly. Sorry !
Do you want me to make another PR ?
Yes pls
Done in #383
Fixes #374