search

krisk / Fuse

Lightweight fuzzy-search, in JavaScript
https://fusejs.io/
Apache License 2.0
17.89k stars 759 forks source link

fix: ensure string before checking for blank #508

Closed mrdivyansh closed 2 years ago

mrdivyansh commented 3 years ago

The code crashes if value is an object.

Screen Shot 2020-10-29 at 12 20 00 PM

https://jsfiddle.net/hza6d3ge/

joaobibiano commented 3 years ago

The code crashes if value is an object.

Screen Shot 2020-10-29 at 12 20 00 PM

https://jsfiddle.net/hza6d3ge/

This solution will care about Dates and Object? I think it is not. We can make a JSON.stringify if it is an object

davidkhierl commented 3 years ago

ping

BernieCr commented 3 years ago

Is there any way to help moving this forward?

mrdivyansh commented 2 years ago

I am closing the PR as @krisk has already taken the change as part of his commit https://github.com/krisk/Fuse/commit/1de1dffa3f16992e21d817370e2b5d9611d3ad6d.

Thanks @krisk

cc @johnnynomad @davidkhierl @joaobibiano