krisk / Fuse

Lightweight fuzzy-search, in JavaScript
https://fusejs.io/
Apache License 2.0
17.79k stars 756 forks source link

Safari11/IE11 compatibility. Why ESM target is es6? #553

Closed nghiepdev closed 3 years ago

nghiepdev commented 3 years ago

Describe the bug

Currently, the browser of my clients broken when they use Mobile Safari 11 browser. Because fuse.js set the target is es6.

So, Why fuse.js set target is es6 in tsconfig.json? But not es5.

{
  "compilerOptions": {
    "module": "es6",
    "lib": ["es6"],
    "target": "es6"
  }
}

You can see https://github.com/krisk/Fuse/blob/master/dist/fuse.esm.js contains a syntax of es6.

Version

fuse.js@6.4.6

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

jdanil commented 3 years ago

I'm facing this one too. @krisk it looks like there are two open prs that would address this #383 and #423. Would it be possible to merge and release one of these?

stevenwchien commented 2 years ago

Hit this bug as well - is this going to be addressed? It sounds like es5 is the correct target