fix(typescript): `fieldNormWeight` should be optional, fixes #650

krisk / Fuse

Lightweight fuzzy-search, in JavaScript

https://fusejs.io/

Apache License 2.0

17.77k stars 754 forks source link

Closed BenJenkinson closed 2 years ago

BenJenkinson commented 2 years ago

The fieldNormWeight config option has a default value of 1, and can therefore be optional (like the other config options)

Omitting fieldNormWeight was valid in <= 6.5.3 (though only because it was missing from the type definition), and is now unnecessarily required in 6.6.0

huzaifahj commented 2 years ago

Created a duplicate pull request before finding this one. Agreed!

BenJenkinson commented 2 years ago

This would fix #650

KoltesDigital commented 2 years ago

Haha I was also too hurried.

I repeat here for the maintainers: FYI you may be interested in built-in Partial type to automatically flag all properties to be optional.

krisk commented 2 years ago

Fixed in latest.