Fix rate limit of 600 requests per minutes on Gitlab.com

kriskbx / gitlab-time-tracker

🦊🕘 A command line interface for GitLab's time tracking feature.

GNU General Public License v2.0

458 stars 82 forks source link

Fix rate limit of 600 requests per minutes on Gitlab.com #106

Closed jdecaron closed 4 years ago

jdecaron commented 4 years ago

This is a simple fix, maximum of 10 requests per seconds = maximum of 600 requests per minutes. It does slow down a bit the report but it prevent a fatal error. It's possible to design a more sophisticated fix but it will be more complex with more states to manage. It would be more prone to bugs. I favor simplicity over maximum speed.

adescoms commented 4 years ago

Hi, this PR would help us to solve https://github.com/kriskbx/gitlab-time-tracker/issues/82 and https://github.com/kriskbx/gitlab-time-tracker/issues/73 because we're overrating the GitLab limit (10 requests per second), can I help in something to move it forward? @kriskbx @jdecaron

cgdobre commented 4 years ago

PS: also update and include the yarn.lock file because the CI job fails without it

cgdobre commented 4 years ago

PS2: goes without saying, if you need any help with the changes, just ask.

coveralls commented 4 years ago

Coverage remained the same at 65.979% when pulling e032d1c8ad44b9341d6e966e48c5c500c013f6dc on jdecaron:fix-rate-limit into e059f1fad60ce4f5cc5fc63110906a840bdd49d0 on kriskbx:master.