search

kriskowal / q-io

Interfaces for IO using Q promises in JavaScript on Node
http://documentup.com/kriskowal/q-io
MIT License
317 stars 73 forks source link

Bump version of collections to avoid conflict with ES6 #151

Closed scandox closed 8 years ago

scandox commented 8 years ago

I ran into a hard to diagnose problem using harmony with node 4.2.1. In the end I figured out it was the version of collections being used by q-io, which was bundled with https://github.com/SLaks/Styliner

The native find function is overwritten by the one in collections, which appears to actually fulfill the function of findIndex. Anyway I updated collections to version 2.0.2 and nothing obvious broke. I know it probably isn't that straightforward...but once ES6 is widespread it is going to come up a bit.

kriskowal commented 8 years ago

Please try q-io@2 from the v2 branch. It has the collections upgrade.

scandox commented 8 years ago

Ok sorry didn't see that. I'll raise an issue with the Styliner repo and see if they can move to the v2 branch.

Thanks.

arikon commented 8 years ago

@kriskowal q-io@2 depends on q@2 which is still experimental. Am I right?