search

kriskowal / q-io

Interfaces for IO using Q promises in JavaScript on Node
http://documentup.com/kriskowal/q-io
MIT License
317 stars 73 forks source link

Fix incorrect version check #153

Closed gagern closed 8 years ago

gagern commented 8 years ago

As it stands, the version check will ensure that the major version is non-negative and that the minor version is at least 10. Current versions, with major version 4 or 5 but single-digit minor versions, are not matched by this. Instead we can check whether the major version is at least 1 or the minor version is at least 10, assuming in the latter case that the major version cannot be less than 0 so we don't have to check for that.

This fixes #149 except on very old versions of node.

kriskowal commented 8 years ago

@gagern I’ve added you to the list of authorized npm publishers for q-io. I will also give you contributor access to this repository.

gagern commented 8 years ago

@kriskowal Thanks. But as long as you are around to do so, I don't see me publishing releases on npmjs unless you explicitely ask me to do so.

kriskowal commented 8 years ago

I don’t have bandwidth presently. You are welcome to publish.

gagern commented 8 years ago

1.13.2 published. Thanks.