search

kriskowal / q-io

Interfaces for IO using Q promises in JavaScript on Node
http://documentup.com/kriskowal/q-io
MIT License
317 stars 73 forks source link

Fix incorrect version check #155

Closed nknapp closed 8 years ago

nknapp commented 8 years ago

This is a cherry-pick of commit 061284b473ec80dfe4c891d5de4b7b330da2a187 by Martin Gagern to fix #149

The original commit message is:

As it stands, the version check will ensure that the major version is non-negative AND that the minor version is at least 10. Current versions, with major version 4 or 5 but single-digit minor versions, are not matched by this. Instead we can check whether the major version is at least 1 OR the minor version is at least 10, assuming in the latter case that the major version cannot be less than 0 so we don't have to check for that.

kriskowal commented 8 years ago

See #159

kriskowal commented 8 years ago

(Thank you @nknapp, my apologies for my lack of vigilance on this repository)