spec: don't use domain.dispose()

kriskowal / q

A promise library for JavaScript

MIT License

14.94k stars 1.2k forks source link

spec: don't use domain.dispose() #823

Closed addaleax closed 6 years ago

addaleax commented 6 years ago

domain.dispose() has been emitting a runtime deprecation warning since 2013 (!) and is removed in Node 9. There is no reason to call it for these tests, so the call can safely be removed.

benjamingr commented 6 years ago

@kriskowal/@domenic this requires a version release and should be done to not cause Q to break on Node 9. Any chance either of you could do a release on NPM?

kriskowal commented 6 years ago

Released in v1.5.1

addaleax commented 6 years ago

Nice, thank you both!