Add bindings for English Y tehta above tengwa

kriskowal / tengwarjs

A Tengwar (J.R.R. Tolkien’s Elvish alphabet) transcriber for ES5 and HTML5

http://tengwar.3rin.gs

MIT License

58 stars 9 forks source link

Add bindings for English Y tehta above tengwa #32

Closed kriskowal closed 4 years ago

kriskowal commented 4 years ago

This includes the relevant changes to show the tehta above every tengwa in both fonts in the proofs, and the necessary kerning adjustments for each font.

Fixes #28

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/kriskowal/tengwarjs/a6s919zhv 🌍 Preview: https://tengwarjs-git-y-above.kriskowal.now.sh

kriskowal commented 4 years ago

From the attached proofs, here are the resulting kerning tables:

dreamingfifi commented 4 years ago

Looks nice!

kriskowal commented 4 years ago

In the above proof, I noticed that the Y above did not combine with silme, so I’ve added a rule to forbid that combination. This will cause the transcriber to use silme nuquerna automatically.

kriskowal commented 4 years ago

Looks nice!

I’ll take this as an approved review. There’s a button where you can comment and express that you approve the change. In the future, any change proposed that passes tests can be merged by the submitter if they get any other collaborator to approve.

dreamingfifi commented 4 years ago

Oh? Which button it that? I'm still learning my way around this place.

kriskowal commented 4 years ago