Cover more cases for silent final E

kriskowal commented 4 years ago

Previously, English "axe" in the mode for general use was rendered as voiced. This change addresses the case and introduces a alternate notation to explicitly mark as voiced, in addition to daieresis.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/kriskowal/tengwarjs/hjgmlqmve 🌍 Preview: https://tengwarjs-git-axe.kriskowal.now.sh

kriskowal commented 4 years ago

Hi - what is the 'alternate notation to explicitly mark as voiced' - is it a keystroke combination?

Either explicit diaeresis ë or e` imply that an e must be voiced.

theringmaker commented 4 years ago

Cool - got it :)

On Wed, Oct 30, 2019 at 11:55 AM Kris Kowal notifications@github.com wrote:

Hi - what is the 'alternate notation to explicitly mark as voiced' - is it a keystroke combination?

Either explicit diaeresis ë or e` imply that an e must be voiced.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/kriskowal/tengwarjs/pull/44?email_source=notifications&email_token=ANM3ANO3V2VQQNS44IHJRR3QRC5MPA5CNFSM4JFP3M3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECSLKKQ#issuecomment-547665194, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANM3ANPM6UL5AFFQ4GTZHSDQRC5MPANCNFSM4JFP3M3A .

--

Cheers

Halfdan

Halfdan Hansen

Jens Hansen - Gold & Silversmith │320 Trafalgar Square, Nelson, 7010 NZ │+64 3 548 0640 <+64%203-548%200640>

jenshansen.com http://www.jenshansen.com/ │Visit Facebook https://www.facebook.com/theringmaker/ │ Visit Instagram https://www.instagram.com/theringmaker/

dreamingfifi commented 4 years ago

Are you talking about words like "be, me, we, Jesse"?

kriskowal / tengwarjs

Cover more cases for silent final E #44