search

kriskowal / tengwarjs

A Tengwar (J.R.R. Tolkien’s Elvish alphabet) transcriber for ES5 and HTML5
http://tengwar.3rin.gs
MIT License
58 stars 9 forks source link

Fix transcription of `unque` in the classical mode #64

Closed kriskowal closed 3 years ago

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kriskowal/tengwarjs/dduveebgh
✅ Preview: https://tengwarjs-git-unque.kriskowal.vercel.app

kriskowal commented 3 years ago

To verify this change, scroll up and click on the "Preview" link posted by the Vercel deployment bot. Then, on the test deployment, click "Select Mode", then select Classical mode, either as specifically attested by Namarie, or a custom variant. Then type "unque" or similar Quenya words with the "nq[u]" cluster and verify the resulting transcription.

dreamingfifi commented 3 years ago

Looks good!

kriskowal commented 3 years ago

Looks good. In general, in Quenya mode, "QU" should be handled as "Q"

Thank you. The treatment of Q[U] without the prefix N is captured here:

https://github.com/kriskowal/tengwarjs/pull/64/files#diff-158d7d7deaf2f3917f94dc535c28d021ae530f5312795bdf614025fa6cbae360R275-R282

It seems I neglected the pre-nasal, but this should fix it generally.

The treatment here and there is to recognize both Q and QU as equivalent, and replaying the second letter if not U to the next parser state.