Fix bug where all temporary listeners cleared when using block

krisleech / wisper

A micro library providing Ruby objects with Publish-Subscribe capabilities

3.27k stars 151 forks source link

Fix bug where all temporary listeners cleared when using block #175

Closed gondalez closed 5 years ago

gondalez commented 5 years ago

This is a rebuild of #142 off master but with extra documentation. Thanks to @0x0badc0de for the code. I tried to cherry pick his commit but it seems to have been deleted since.

The bug bit us and caused us to shift to global listeners with manually managed unsubscribe. That in turn bit us because we didn't realise the process/thread difference between the two.

Our hope is the added docs will save others this pain in the future 🙏 Thanks again for the great gem!

coveralls commented 5 years ago

Coverage increased (+0.003%) to 99.878% when pulling c514e0ed890e783ef09576bebe11314ffc17ed7c on appbot:master into 8773f751fa94e2c75e883c20111c852921bd70ba on krisleech:master.

krisleech commented 5 years ago

Thanks! I will plan a release soon.