search

krisleech / wisper

A micro library providing Ruby objects with Publish-Subscribe capabilities
3.27k stars 151 forks source link

Ruby 3 support #205

Closed krisleech closed 1 year ago

krisleech commented 1 year ago

fixed up version of https://github.com/krisleech/wisper/pull/197 to prepare for release

krisleech commented 1 year ago

@doit @jstoks @merringtion @thirunjuguna

I branched off https://github.com/krisleech/wisper/pull/197 and created a new PR, rebased on main, fixed the conflicts and squashed the commits to tidy up the history.

I've added @jstoks @merringtion @thirunjuguna as co-authors and @doits is the author to the original commit. Hope that is okay, did I miss anyone?

Any final comments/feedback before I prepare a release candidate after merging and then a 3.0 release.

patrickemuller commented 1 year ago

@krisleech kudos to you buddy, what a great work!

synth commented 1 year ago

Thank you for this update! One friendly request is to update the VERSION file. On the master branch it is still 2.0.x even though the commit has been tagged in Github as an 3.x.x.rc already. I think this would allow easier version control in our Gemfiles. For instance, right now, I can't do: 

gem 'wisper', '~> 3.0.0.rc1', github: 'krisleech/wisper'

because it doesn't know about it.

I can do this: 

gem 'wisper', github: 'krisleech/wisper', branch: 'master'

# or

gem 'wisper', github: 'krisleech/wisper', tag: 'v3.0.0.rc1'

I think the former is preferred though. Thank you!

raszi commented 1 year ago

I believe wisper-sidekiq will need to be fixed as well:

https://github.com/krisleech/wisper-sidekiq/blob/1061ff02fed7298f616298479c8e98081297231a/lib/wisper/sidekiq.rb#L18