search

krisnova / naml

Convert Kubernetes YAML to Golang
Apache License 2.0
1.26k stars 38 forks source link

use goname pattern in clusterrole #47

Closed fkautz closed 2 years ago

fkautz commented 2 years ago

ClusterRole now follows goname pattern that was set in Deployments.

Also extracts goName into its own method for simplifcation.

Signed-off-by: Frederick F. Kautz IV fkautz@alumni.cmu.edu

krisnova commented 2 years ago

I just ran into this in my last PR with pods - we definetly should call goname for every object

fkautz commented 2 years ago

I think it's a good idea. This PR is a prelude to adding it to every object, since I wanted to put in the goName function first.

fkautz commented 2 years ago

new push to resolve the conflict.