krisppurg / dimscord

A Discord Bot & REST Library for Nim.
https://krisppurg.github.io/dimscord/
MIT License
222 stars 20 forks source link

[WIP] fixes #112; alt design to #101 using inheritance instead of global vars #113

Closed nayr7 closed 1 year ago

nayr7 commented 1 year ago

fixes https://github.com/krisppurg/dimscord/issues/112; alternative to https://github.com/krisppurg/dimscord/pull/101 using inheritance to allow referencing the current state of the user's RestApi from inside the library; is also likely to integrate well with the current design of https://github.com/krisppurg/dimscord/pull/110

important info/considerations:

tasks:

krisppurg commented 1 year ago

may I ask why make a new PR when you could just rewrite the original PR instead?

nayr7 commented 1 year ago

I keep the other PR around for now in case I can fix/improve it, alongside a less messy git history in case https://github.com/krisppurg/dimscord/pull/101 is to be discarded in favor of this one