Comparing Option[string] to Option[string]

krisppurg / dimscord

A Discord Bot & REST Library for Nim.

https://krisppurg.github.io/dimscord/

MIT License

222 stars 22 forks source link

Comparing Option[string] to Option[string] #28

Closed ire4ever1190 closed 3 years ago

ire4ever1190 commented 3 years ago

Fix issue where an issue where the emoji parameters id and name are being compared to a string when they should be compared to an Option[String]

krisppurg commented 3 years ago

Oops, I forgot to push to misc. Could you just change it to isNone instead of some("")?

ire4ever1190 commented 3 years ago

yup, will do

krisppurg commented 3 years ago

Alright, I'll make a patch release later.

ire4ever1190 commented 3 years ago

that is how you want it yeah?

krisppurg commented 3 years ago

I mean without the brackets (just making sure code is clear and consistent)