search

krisppurg / dimscord

A Discord Bot & REST Library for Nim.
https://krisppurg.github.io/dimscord/
MIT License
222 stars 22 forks source link

Fix getGuildChannel #52

Closed ire4ever1190 closed 3 years ago

ire4ever1190 commented 3 years ago

getGuildChannel was trying to request /guilds/{guild.id}/channels/{channel.id} but it returned a 404 error and I could not find it anywhere in the discord docs but I did find /channels/{channel.id} which correctly returned the channel

I changed the name to getChannel so it fits with deleteChannel do you think it is a good name change or should I revert it back?

krisppurg commented 3 years ago

Doesn't getChannel work besides no guild, if so then it's fine.

ire4ever1190 commented 3 years ago

sorry I don't understand? The updated getChannel works but getGuildChannel returned 404

krisppurg commented 3 years ago

What I meant was in the discord api. Doesn't it work with no guild id?

ire4ever1190 commented 3 years ago

Yes Removing the guild id (and so removing this part of the url/guilds/{guild.id) works