search

krisrs1128 / clouds_dist

Simulation of low-clouds, from weather measures.
4 stars 1 forks source link

Pull Request Etiquette #92

Closed vict0rsch closed 4 years ago

vict0rsch commented 4 years ago

Hey, as I've seen in other projects, a good software engineering practice is to put [WIP] at the beginning of a PR's title when it's "work in progress". That will prevent unwanted merges.

For instance, @mustafaghali created a Quantization PR. But from our discussion, it's was not what we had in mind. So he changed it. And now I don't know if it should be merged or not.

So if a PR's not ready to be merged, add [WIP] in its title :)

vict0rsch commented 4 years ago

add a 👍 when seen and we'll close the issue

vict0rsch commented 4 years ago

@krisrs1128 you've seen this already but I'm updating it:

I added a "Waiting for Review" column in the project so that we know what's pending