search

krisselden / draggable-each

jquery-ui-sortable as an ember component
MIT License
14 stars 5 forks source link

Breaks with Ember 1.8.* #4

Open kmmathis opened 9 years ago

kmmathis commented 9 years ago

Upgrading Ember to 1.8.1 results in the entire list being dragged rather than a single item. Could this have something to do with the metamorph tags being removed?

stefanpenner commented 9 years ago

Unfortunately this lib must reach into internals to accomplish its task and those internals have changed. So we will have to make the appropriate changes.

krisselden commented 9 years ago

@kmmathis there are WIP branches, if you can make the leap to 1.11, this branch is very close to landing.

aboma commented 9 years ago

I have a fork that upgrades draggable-each to work with ember-1.10 and the new Glimmer view system. The changes might be something of a hack but they work on my project. The only issue I currently have is that the jQuery UI draggable plugin doesn't allow moving an item to another list now for some unknown reason, and on Chrome the draggable plugin doesn't work at all for some reason. I've been waiting until I figure this out before I make a pull request. Help with debugging it would be great.

The repo is here: https://github.com/aboma/draggable-each

aboma commented 9 years ago

The fix for ember 1.8.1 should be a single line (I think). At least the issue of the whole list being dragged is fixed by changing draggable-each.js line 40 from:

if (itemSelector)  { options.item  = itemSelector; }

to

if (itemSelector)  { options.items  = itemSelector; }