krisselden / ember-macro-benchmark

Benchmark recording of an ember app with running with 2 versions of Ember.
25 stars 9 forks source link

report.R should come from chrome-tracing #15

Closed rondale-sc closed 7 years ago

rondale-sc commented 7 years ago

The current instructions on the README to generate the report call for the user to generate the png's using report.R. Unfortunately, the repo's version of this report is out-of-sync with chrome-tracing. And as a result the results.json is incompatible with our own report.R.

The quick-fix solution is to clone chrome tracing and then generate the report (which is much nicer in chrome-tracing) using its report.R and plot.R. You can point it to the results.json file in your repo and it will put a PDF at that location with your aggregate results (the plot.R).

I've created a PR in chrome-tracing to ship those plot.R and report.R with chrome-tracing's distribution, so that we can have EMB use those via an npm script.

https://github.com/krisselden/chrome-tracing/pull/8