search

kristerkari / react-native-sass-transformer

Use Sass to style your React Native apps.
MIT License
219 stars 19 forks source link

Replaces deprecated node-sass with sass #51

Closed almeidabbm closed 2 years ago

almeidabbm commented 2 years ago

Functions such as math.div() would result in error when using node-sass error: src/styles/index.scss: Invalid CSS after " @return math": expected expression (e.g. 1px, bold), was ".div($px, $base) * ".

Replacing it with the up to date sass package fixed the issue. sass will expose the same API as node-sass: https://sass-lang.com/blog/libsass-is-deprecated

PodaruDragos commented 2 years ago

This will also most likely fix issues with package not installing on node 17. Is there anything that is blocking this ?

kristerkari commented 2 years ago

Thanks! I think that this a good to get merged.

almeidabbm commented 2 years ago

Thanks! I think that this a good to get merged.

I do believe you will have to be the one merging as I do not have permissions for it.

kristerkari commented 2 years ago

I know, but I still need to try out the changes before merging. It's always good to verify that nothing will break.