kristerkari / react-native-svg-transformer

Import SVG files in your React Native project the same way that you would in a Web application.
MIT License
1.58k stars 115 forks source link

Expo SDK 50 crashes when apply metro config #329

Closed netojose closed 9 months ago

netojose commented 9 months ago

Related to #328

When using Expo SDK 50:

When comment all changes, everything works:

// Learn more https://docs.expo.io/guides/customizing-metro
const { getDefaultConfig } = require('expo/metro-config')

module.exports = (() => {
  /** @type {import('expo/metro-config').MetroConfig} */
  const config = getDefaultConfig(__dirname)

  //   const { transformer, resolver } = config

  //   config.transformer = {
  //     ...transformer,
  //     babelTransformerPath: require.resolve('react-native-svg-transformer')
  //   }
  //   config.resolver = {
  //     ...resolver,
  //     assetExts: resolver.assetExts.filter((ext) => ext !== 'svg'),
  //     sourceExts: [...resolver.sourceExts, 'svg']
  //   }

  return config
})()

But when uncomment, and apply the changes:

// Learn more https://docs.expo.io/guides/customizing-metro
const { getDefaultConfig } = require('expo/metro-config')

module.exports = (() => {
  /** @type {import('expo/metro-config').MetroConfig} */
  const config = getDefaultConfig(__dirname)

  const { transformer, resolver } = config

  config.transformer = {
    ...transformer,
    babelTransformerPath: require.resolve('react-native-svg-transformer')
  }
  config.resolver = {
    ...resolver,
    assetExts: resolver.assetExts.filter((ext) => ext !== 'svg'),
    sourceExts: [...resolver.sourceExts, 'svg']
  }

  return config
})()

The app crashes:

error: node_modules/expo-router/_ctx.ios.js: /Users/joseneto/Projects/intellektu/barber-app/node_modules/expo-router/_ctx.ios.js: Expected fromDir to be of type string, got undefined

Simulator Screenshot - iPhone 12 Pro - 2023-12-23 at 23 27 36

Even without try to import some SVG, just applying the change at the metro.config.js file.

kristerkari commented 9 months ago

Thanks for reporting, I'll try to get #328 in asap

kristerkari commented 9 months ago

New release with a fix is out: https://github.com/kristerkari/react-native-svg-transformer/releases/tag/v1.3.0