kristiandupont / kanel

Generate Typescript types from Postgres
https://kristiandupont.github.io/kanel/
MIT License
888 stars 62 forks source link

Feature / pull request: API-based indexes #559

Open simian-loco opened 6 months ago

simian-loco commented 6 months ago

Background

I use schemas for role-based segmentation of what is available to whom (via postgrest). This means I have apis like the following:

In this example there are two of the same resource "features" on separate schemas pointing to different views. One uses the "users.features" api/schema and the other uses "public.features" api/schema.

Issue

The generateIndexFile generator currently outputs conflicting results for my situation. There are two separate "features" exports) via the generated ${outputPath}/index.ts index file.

Solution

PR: Fix for "duplicate identifier" via generateIndexFile hook for multiple schemas #558

The proposed solution is to use pretty much the same logic as the global index.ts file; but building up the schema-based index.ts files when generating the output, if schemas are being used.

This is currently an "all or nothing" result for someone using schemas. There is either a "global" outputPath index or schema based index files. I would argue that this is prudent given overlapping view names are in-spec for postgresql.

All kanel package tests are passing for what it's worth.

Potential Enhancements

Feel free to edit / feedback / merge / etc.

Thanks for the library!

simian-loco commented 6 months ago

Does config.schemas reference only the schemas added to .kanelrc.js? Are other schemas (e.g. private schemas or extension schemas) not included within .kanelrc.js missing from this method of resolution? resolveType.ts#L162-L201

I am not quite sure where the config.schemas is being produced. Could you point me the way?

Some extra context: the types are resolving, but I am manually setting siNullable and isOptional to true via the config. It seems that the resolution method cannot drill down enough to determine this automatically. This might be because I am deleting the source property via my patch-1 update (deleted in order to resolve the types for the properties).

This actually is probably better discussed here.