search

kristianfreeman / roam-backup

Automated Roam Research backups using GitHub Actions and AWS S3
MIT License
81 stars 53 forks source link

Multi-database support #4 #6

Open Stvad opened 4 years ago

Stvad commented 4 years ago

Ok, this is actually broken, as it tries to go to multiple places in 1 page at the same time. Let me fix that

kristianfreeman commented 4 years ago

this is so awesome!! i didn't know that multi-database support was a thing in roam, but i've seen a bunch of people asking about this so i'm thrilled you took the time to get this PR up!

anything i can do to help it along the finish line? i see a few TODOs in the diff. let me know!

also thanks for the re-indent fix, not sure what happened there!

Stvad commented 4 years ago

This is functional, I think it can be merged as is. TODO's are more of a wish-list for improvements

Stvad commented 4 years ago

There is a bug when switch to JSON export type does not work for large db's, but I don't believe it's related to changes here

Stvad commented 4 years ago

Do you have any concerns you want addressed before merging this?

Stvad commented 4 years ago

👀

kristianfreeman commented 4 years ago

hey @Stvad, sorry for the lack of review on this! i've been pretty bad about my github notifications :| reviewing now

kristianfreeman commented 4 years ago

I had some issues running this: https://github.com/signalnerve/roam-backup/runs/622833348?check_suite_focus=true

@Stvad any ideas?